Hw3.ftp #5
Open
Hw3.ftp #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuken
suggested changes
May 14, 2018
| @@ -0,0 +1,8 @@ | |||
| Я вас любил: любовь еще, быть может, | |||
There was a problem hiding this comment.
файлы для тестов обычно кладут в src/test/resources. а вообще для подобных тестов есть очень удобная штука https://junit.org/junit4/javadoc/4.12/org/junit/rules/TemporaryFolder.html
| /** A server that processes two list requests and receives */ | ||
| public class Server { | ||
| /** Value for request list */ | ||
| public static int LIST_REQUEST = 1; |
There was a problem hiding this comment.
хорошо бы информацию о сетевом протоколе как-то переиспользовать между клиентом и сервером
| import java.net.Socket; | ||
|
|
||
| /** A server that processes two list requests and receives */ | ||
| public class Server { |
There was a problem hiding this comment.
тесты это хорошо, но хотелось бы ещё консольный UI, чтобы запустить клиент и сервер и поперекачивать файлы
jzuken
suggested changes
Jun 14, 2018
| List<Pair<String, Boolean>> files = client.list(dirTestList1.getAbsolutePath() + "/test3"); | ||
| assertEquals(0, files.size()); | ||
|
|
||
| } catch (IOException e) { |
There was a problem hiding this comment.
в тестах не принято ловить исключения. если тест должен бросать исключение, используйте параметр expected аннотации Test. а если не должен, то пишите throws у метода
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.